Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Speed" section in Settings from Chromium still visible when searched #41565

Closed
3 of 6 tasks
Brave-Matt opened this issue Oct 10, 2024 · 1 comment · Fixed by brave/brave-core#25993
Closed
3 of 6 tasks

"Speed" section in Settings from Chromium still visible when searched #41565

Brave-Matt opened this issue Oct 10, 2024 · 1 comment · Fixed by brave/brave-core#25993
Assignees
@emerick
Labels
feature/settings OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.74.x - Beta

Comments

@Brave-Matt
Copy link

Description

We have hidden the "speed" section in Settings --> Performance so that it is not visible when looking through Settings. However, if you search for it, it still shows up:

Image

We should ensure that this (and any other) hidden sections do not appear in Brave, even when searched.

Steps to reproduce

  1. Search "speed" in Settings

Actual result

Hidden "Speed" section appears

Expected result

Section should remain hidden

Reproduces how often

Easily reproduced

Brave version (brave://version info)

v1.70.126

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Internal conversation here:
https://bravesoftware.slack.com/archives/CKNHM4RTK/p1728600038306029
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Oct 11, 2024
@emerick emerick mentioned this issue Oct 15, 2024
Merged
24 tasks
@brave-builds brave-builds added feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core labels Oct 15, 2024
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 15, 2024
@rebron rebron moved this to Completed in Settings Oct 16, 2024
@rebron rebron removed this from Settings Nov 6, 2024
@srirambv srirambv removed feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core labels Nov 14, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Nov 22, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.74.11 Chromium: 131.0.6778.85 (Official Build) beta (64-bit)
-- | --
Revision | c777fe11bc7afc00156e58af64a6a5bb9559da7d
OS | Windows 11 Version 24H2 (Build 26100.2314)

Verified the issue using STR from #41565 (comment)

Confirmed Speed setting is no longer visible when searched Speed in the brave://settings

example example
Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/settings OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.74.x - Beta
Development

Successfully merging a pull request may close this issue.

Hide upstream speed settings brave/brave-core
6 participants
@Brave-Matt @emerick @rebron @srirambv @brave-builds @MadhaviSeelam