Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private windows redesign #37596

Closed
aguscruiz opened this issue Apr 15, 2024 · 3 comments · Fixed by brave/brave-core#25850
Closed

Private windows redesign #37596

aguscruiz opened this issue Apr 15, 2024 · 3 comments · Fixed by brave/brave-core#25850
Assignees
Labels
Milestone

Comments

@aguscruiz
Copy link

aguscruiz commented Apr 15, 2024

We need to redesign private windows to present information in a friendlier way.

Design ready here:
https://www.figma.com/design/jt7tV0UsU7XhJXR2B8807E/Private-and-Tor-Windows---Nala?node-id=37%3A7636&t=wKzZwmhqCGW5ylK4-1

Actual result

Android

Sorry for the photo, doesn't let me take screenshots.
image

Expected result

image

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@aguscruiz aguscruiz added feature/private-browsing OS/Android Fixes related to Android browser functionality labels Apr 15, 2024
@aguscruiz aguscruiz self-assigned this Apr 15, 2024
@ghost
Copy link

ghost commented Apr 16, 2024

Just want to be nosey and tell you that to take screenshots in private mode you just need to enable brave://flags/#incognito-screenshot

@aguscruiz
Copy link
Author

Just want to be nosey and tell you that to take screenshots in private mode you just need to enable brave://flags/#incognito-screenshot

Oh thanks! Didn't know that 👏

@deeppandya deeppandya added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 29, 2024
@deeppandya deeppandya self-assigned this May 29, 2024
@timchilds timchilds assigned simoarpe and unassigned deeppandya and aguscruiz Sep 16, 2024
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 15, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 22, 2024
@hffvld
Copy link
Contributor

hffvld commented Nov 23, 2024

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 15 AP41.240925.009 release-keys
Brave build: 1.74.8 
Chromium: 131.0.6778.69 (Official Build) beta (64-bit) 

Filed follow-up issue #42470

STEPS:

  1. Follow the STR/TP from (Android) Redesign private tab UI brave-core#25850 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the new Private tab UI is shown as expected.
  • Verified that tapping the Try free for 7 days link opened the VPN paywall.
  • Verified that closing the VPN paywall returns to the Private tab.

Galaxy Tab S8
Dark theme Light theme
1 2
1 2
Dark theme Light theme
1 2
1 2
2024-11-22_15-16-59.mp4
Pixel 7
Dark theme Light theme
1 2
1 2
1 2
2024-11-22_14-51-04.mp4

@hffvld hffvld added QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants