Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] YT Improvements: Quick-search engines bar #32843

Closed
timchilds opened this issue Sep 7, 2023 · 3 comments · Fixed by brave/brave-core#26309
Closed

[Android] YT Improvements: Quick-search engines bar #32843

timchilds opened this issue Sep 7, 2023 · 3 comments · Fixed by brave/brave-core#26309
Assignees
Labels
enhancement OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Milestone

Comments

@timchilds
Copy link

Description

See Quick-search engines bar with YouTube and Requirements sections here:
https://bravesoftware.slack.com/archives/CELA35G5S/p1694106384308469?thread_ts=1671572756.471319&cid=CELA35G5S

@timchilds timchilds added enhancement QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Sep 7, 2023
@timchilds timchilds changed the title [Android] YT Improvements: Quick-search engines bar with YouTube [Android] YT Improvements: Quick-search engines bar Sep 7, 2023
@deeppandya deeppandya added the priority/P2 A bad problem. We might uplift this to the next planned release. label Dec 20, 2023
@deeppandya deeppandya assigned deeppandya and unassigned tapanmodh May 27, 2024
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Nov 6, 2024
@Uni-verse Uni-verse added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Blocked and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 22, 2024
@Uni-verse
Copy link
Contributor

Need uplifts to 1.74 created

@hffvld hffvld added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/Blocked labels Nov 27, 2024
@hffvld
Copy link
Contributor

hffvld commented Nov 27, 2024

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 15 AP41.240925.009 release-keys
Brave build: 1.74.13 
Chromium: 131.0.6778.85 (Official Build) beta (64-bit) 

Filed follow-up issue #42567

Fresh profile

STEPS:

  1. Fresh install Brave Beta 1.74.13 or higher
  2. Go through onboarding
  3. Open NTP
  4. Tap in the URL search bar
  5. Type a query > Verify that the QSE toolbar is shown and includes the YT thumbnail
  6. Tap YT search thumbnail > Verify that the YT website is opened and search results are shown
  7. Type another query in the URL search bar > Tap ⚙️ icon > Verify that YT is shown
  8. Disable YT > Close the settings screen
  9. Type a query again > Verify that YT is not shown
  10. Re-enable YT > Type a query > Verify that YT is shown and works

ACTUAL RESULTS:

  • Verified that QSE is not shown until the user starts typing a query in the URL search bar.
  • Verified that the YT search is shown in the QSE toolbar.
  • Verified that the YT search works and that the search results are shown as expected on YT website.
  • Verified that YT is shown in the QSE settings.
  • Verified that YT can be disabled/enabled in the QSE settings.

Galaxy Tab S8

1 2 3
1 2 3
1 2 3

Pixel 7

1 2 3
1 2 3
1 2 3
Upgraded profile

STEPS:

  1. Install Brave Beta 1.74.10 (it was previously available in the Play Store)
  2. Go through onboarding
  3. Open NTP
  4. Tap in the URL search bar > Type a query > Observe that YT search thumbnail is not shown
  5. Tap ⚙️ icon > Observe that YT search is not shown
  6. Upgrade Brave to Beta 1.74.13 or higher
  7. Launch Brave > Type a query again > Verify that YT search thumbnail is shown
  8. Tap ⚙️ icon > Verify that YT is shown
  9. Close the settings screen
  10. Type a query > Tap YT > Verify that results are shown with YT search
  • Observed that the YT search didn't shown in the QSE toolbar and in the settings after Brave upgraded to a new build.

Galaxy Tab S8

2024-11-27_12-26-22.mp4

Pixel 7

2024-11-27_12-23-26.mp4

@hffvld hffvld added QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants