Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new buy user flow #23349

Closed
muliswilliam opened this issue Jun 9, 2022 · 3 comments · Fixed by brave/brave-core#13708
Closed

Implement new buy user flow #23349

muliswilliam opened this issue Jun 9, 2022 · 3 comments · Fixed by brave/brave-core#13708
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.40.x - Release

Comments

@muliswilliam
Copy link

muliswilliam commented Jun 9, 2022 •
edited
Loading

Implement new user flow that shows all onramp providers (currently Ramp and Wyre).

The description for both providers has been updated to: "Buy crypto with Visa or Mastercard"

Image
@muliswilliam muliswilliam self-assigned this Jun 9, 2022
@muliswilliam muliswilliam added release-notes/include priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop feature/web3/wallet Integrating Ethereum+ wallet support labels Jun 9, 2022
@muliswilliam muliswilliam added this to the 1.40.x - Beta milestone Jun 9, 2022
@muliswilliam muliswilliam moved this from Backlog to In Review in Web3 Jun 9, 2022
@muliswilliam muliswilliam mentioned this issue Jun 9, 2022
Merged
25 tasks
Repository owner moved this from In Review to Done in Web3 Jun 9, 2022
@kjozwiak
Copy link
Member

@muliswilliam changing the milestone to 1.41.x as this landed in master which is currently 1.41.x and not 1.40.x. Please see https://github.com/brave/brave-browser/wiki/Triage-Guidelines#uplifting 👍 Once brave/brave-core#13731 has been uplifted into 1.40.x, the @brave/uplift-approvers team will move the issue into the 1.40.x milestone.

@kjozwiak kjozwiak mentioned this issue Jun 14, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

The above will require 1.40.99 or higher for 1.40.x verification 👍

@srirambv
Copy link
Contributor

Brave 1.40.99 Chromium: 102.0.5005.125 (Official Build) beta (64-bit)
Revision 07573b09e385116e620ed12d5ef2402c4bfa929f-refs/branch-heads/5005@{#1159}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#13708
  • Verified a new button to Select purchase method... is shown on the Buy widget
  • Verified selecting it shows available providers
  • Verified both Ramp and Wyre is shown for available tokens/network
  • Verified only Ramp is shown for tokens/network when applicable
  • Encountered #23425
23349-Linux.mp4
23349-Windows.mp4
23349-macOS.mov

@kjozwiak kjozwiak mentioned this issue Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.40.x - Release
Development

Successfully merging a pull request may close this issue.

Implement buy options new design brave/brave-core
3 participants
@kjozwiak @srirambv @muliswilliam