Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add some keyword only arguments to add_button #93

Closed
dstansby opened this issue Apr 21, 2023 · 0 comments · Fixed by #95
Closed

[Feature] Add some keyword only arguments to add_button #93

dstansby opened this issue Apr 21, 2023 · 0 comments · Fixed by #95
Labels
enhancement New feature or request

Comments

@dstansby
Copy link
Member

The add_button function has calls that look like this:

add_button(
            "Track tracing",
            self.toggle_methods_layout,
            self.track_seg.toggle_track_panel,
            0,
            1,
            minimum_width=COLUMN_WIDTH,
            alignment=SEGM_METHODS_PANEL_ALIGN,
        )

Out of context of the original signature, the 0 and 1 arguments are a bit myserious. It would be good to convert these to keyword-only arguments in the signature of add_button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant