Skip to content

Commit

Permalink
Renaming nightly tag to edge #708
Browse files Browse the repository at this point in the history
  • Loading branch information
bpatrik committed Sep 2, 2023
1 parent f315e3d commit 57b288f
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 7 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,16 +132,18 @@ jobs:
platforms: ${{ matrix.platforms }}
push: true
tags: bpatrik/pigallery2:experimental-${{ matrix.container }}
- name: Push nightly on new master commit
- name: Push edge on new master commit
# github.ref: branches the format is refs/heads/<branch_name> PRs and Tags are different
if: ${{github.ref == 'refs/heads/master' }}
if: ${{github.ref == 'refs/heads/master' }}
uses: docker/build-push-action@v3
with:
context: .
file: docker/${{ matrix.container }}/Dockerfile.build
platforms: ${{ matrix.platforms }}
push: true
tags: bpatrik/pigallery2:nightly-${{ matrix.container }}
tags: |
bpatrik/pigallery2:edge-${{ matrix.container }}
bpatrik/pigallery2:nightly-${{ matrix.container }}
- name: Push release on new Tag
if: ${{ startsWith(github.ref_type , 'tag') && !github.event.issue.pull_request && matrix.container != 'debian-bullseye'}}
uses: docker/build-push-action@v3
Expand All @@ -151,7 +153,7 @@ jobs:
platforms: ${{ matrix.platforms }}
push: true
tags: |
bpatrik/pigallery2:nightly-${{ matrix.container }}
bpatrik/pigallery2:edge-${{ matrix.container }}
bpatrik/pigallery2:${{ github.ref_name }}-${{ matrix.container }}
bpatrik/pigallery2:latest-${{ matrix.container }}
- name: Push latest on new Tag
Expand All @@ -163,7 +165,7 @@ jobs:
platforms: ${{ matrix.platforms }}
push: true
tags: |
bpatrik/pigallery2:nightly-${{ matrix.container }}
bpatrik/pigallery2:edge-${{ matrix.container }}
bpatrik/pigallery2:${{ github.ref_name }}-${{ matrix.container }}
bpatrik/pigallery2:latest-${{ matrix.container }}
bpatrik/pigallery2:${{ github.ref_name }}
Expand Down
3 changes: 2 additions & 1 deletion docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ You can use [docker](https://docs.docker.com/install/) to run PiGallery2. See al
available tags:
- `v*` (stable): built from the release with the same version name.
- `latest` (stable): same as the latest `v*`, built with debian buster
- `nightly` : built from the current state of `master`. This might break from time to time.
- `edge` : built from the current state of `master`. This might break from time to time.
- `nightly` : Deprecated. Rename to `edge`. See #708.

**Note**: Some changes may require database reset or config changes, see [#317](https://github.com/bpatrik/pigallery2/issues/317) (If you want to reduce the frequency of those, use stable builds (`latest`)

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions src/frontend/app/ui/frame/frame.component.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<ngx-loading-bar [includeSpinner]="false" color="#337ab7" height="3px"></ngx-loading-bar>
<div class="alert alert-danger" role="alert">
You are using the :nightly docker tag. nightly is renamed to :edge and discontinued.
<a href="https://github.com/bpatrik/pigallery2/issues/708">See #708</a>.
</div>
<div #navContainer class="navbar-container auto-hide-navbar"
[class.navbar-keep-top]="navbarKeepTop || fixNavbarOnTop"
[class.hide-navbar]="!navbarKeepTop && shouldHideNavbar"
Expand Down

0 comments on commit 57b288f

Please sign in to comment.