Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Fix PHPBench workflow #1206

Merged
merged 6 commits into from
Nov 24, 2023
Merged

build: Fix PHPBench workflow #1206

merged 6 commits into from
Nov 24, 2023

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented Nov 24, 2023 •
edited
Loading

Follow up of #1204 which required to have a workflow landing in main.

This PR:

  • Moves the res directory included for the benchmarked code to avoid potential FS issues.
  • Run another job: the PHPBench for the PR, without comparing with main, to have some feedback in case the PHPBench in main fails.
  • Do not fail if the performance target is not met: this is work for the future.

@theofidry theofidry changed the title ci: Fix PHPBench workflow build: Fix PHPBench workflow Nov 24, 2023
@theofidry theofidry merged commit 207ced1 into box-project:main Nov 24, 2023
57 of 61 checks passed
@theofidry theofidry deleted the build/fix-bench branch November 24, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theofidry