Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmetic] Full support to --no-ansi option especially for icons #1400

Open
llaville opened this issue Aug 4, 2024 · 2 comments
Open

[Cosmetic] Full support to --no-ansi option especially for icons #1400

llaville opened this issue Aug 4, 2024 · 2 comments

Comments

@llaville
Copy link
Contributor

llaville commented Aug 4, 2024

The Symfony Console Application has, by defaut a --no-ansi option that will allows to turn off colors on CLI output.

BTW, BOX as icons in front of command description, and should be dropped when --no-ansi option is in effect.

See current results

box-no-ansi

@theofidry
Copy link
Member

Technically emojis are not ANSI so they can be part of plain text, but maybe it was wrong of me to assume they would be fine in a plain text output.

I would need to check, but implementation this looks difficult: the description is provided before any runtime information is given so you do not know if it's ANSI or not at that time (and usually you do not care as ANSI tags are removed by the formatter if not ansi. Maybe there could be a way by adding a specific tag which would be stripped down the same way

@llaville
Copy link
Contributor Author

llaville commented Aug 5, 2024

Don't waste your time on this issue, it's very few important after all !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants