From f987f7fb0dfb72e378d3428ee01ccdc72294cab7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Th=C3=A9o=20FIDRY?= <theo.fidry@gmail.com>
Date: Mon, 16 Oct 2023 21:44:56 +0200
Subject: [PATCH] fix: Do not rethrow the exception in the info command

Since `PharInfo` has been introduced, the exception should be clear and
easily understandable so this extra catch logic is no longer necessary.
---
 src/Console/Command/Info.php       | 32 ++++++++----------------------
 tests/Console/Command/InfoTest.php | 22 +++-----------------
 2 files changed, 11 insertions(+), 43 deletions(-)

diff --git a/src/Console/Command/Info.php b/src/Console/Command/Info.php
index 93e807442..5649ced2f 100644
--- a/src/Console/Command/Info.php
+++ b/src/Console/Command/Info.php
@@ -24,7 +24,6 @@
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Filesystem\Path;
-use Throwable;
 use function implode;
 use function is_array;
 use function realpath;
@@ -129,30 +128,15 @@ public static function showInfo(string $file, IO $io): int
         $maxDepth = self::getMaxDepth($io);
         $mode = $io->getOption(self::MODE_OPT)->asStringChoice(self::MODES);
 
-        try {
-            $pharInfo = new PharInfo($file);
+        $pharInfo = new PharInfo($file);
 
-            return self::showPharInfo(
-                $pharInfo,
-                $io->getOption(self::LIST_OPT)->asBoolean(),
-                -1 === $maxDepth ? false : $maxDepth,
-                'indent' === $mode,
-                $io,
-            );
-        } catch (Throwable $throwable) {
-            if ($io->isDebug()) {
-                throw $throwable;
-            }
-
-            $io->error(
-                sprintf(
-                    'Could not read the file "%s".',
-                    $file,
-                ),
-            );
-
-            return ExitCode::FAILURE;
-        }
+        return self::showPharInfo(
+            $pharInfo,
+            $io->getOption(self::LIST_OPT)->asBoolean(),
+            -1 === $maxDepth ? false : $maxDepth,
+            'indent' === $mode,
+            $io,
+        );
     }
 
     /**
diff --git a/tests/Console/Command/InfoTest.php b/tests/Console/Command/InfoTest.php
index 9fdf342c4..31c46eda5 100644
--- a/tests/Console/Command/InfoTest.php
+++ b/tests/Console/Command/InfoTest.php
@@ -24,8 +24,6 @@
 use Symfony\Component\Console\Output\OutputInterface;
 use function extension_loaded;
 use function implode;
-use function preg_replace;
-use function Safe\realpath;
 
 /**
  * @covers \KevinGH\Box\Console\Command\Info
@@ -602,32 +600,18 @@ public static function inputProvider(): iterable
         }
     }
 
-    public function test_it_cannot_provide_info_about_an_invalid_phar_without_extension(): void
+    public function test_it_cannot_provide_info_about_an_invalid_phar(): void
     {
         $file = self::FIXTURES.'/foo';
 
+        $this->expectException(InvalidPhar::class);
+
         $this->commandTester->execute(
             [
                 'command' => 'info',
                 'phar' => $file,
             ],
         );
-
-        $expectedPath = realpath($file);
-
-        $expected = <<<OUTPUT
-
-
-             [ERROR] Could not read the file "{$expectedPath}".
-
-
-            OUTPUT;
-
-        $this->assertSameOutput(
-            $expected,
-            ExitCode::FAILURE,
-            static fn ($output) => preg_replace('/file[\ \n]+"/', 'file "', $output),
-        );
     }
 
     public function test_it_displays_the_error_in_debug_verbosity(): void