From d944fb980ddaf2423643e06ca0a301b5558b8fe3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Th=C3=A9o=20FIDRY?=
 <5175937+theofidry@users.noreply.github.com>
Date: Thu, 9 Nov 2023 22:53:46 +0100
Subject: [PATCH] fix: Allow the info command to work on the old
 RequirementChecker (#1157)

Closes #1126.
---
 fixtures/info/req-checker-old-req.phar       | Bin 151562 -> 151518 bytes
 src/RequirementChecker/Requirement.php       |   2 +-
 tests/Console/Command/InfoTest.php           |   6 +++---
 tests/RequirementChecker/RequirementTest.php |  20 +++++++++++++++++++
 4 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/fixtures/info/req-checker-old-req.phar b/fixtures/info/req-checker-old-req.phar
index 13d1d6e30ecb2ce87e35c385011fbbacbc9bfc82..40676b02e465f061593ca054f0d87855d88e4390 100755
GIT binary patch
delta 470
zcmeBLz<F;z=Z1}p%p6O-CU0TX7KmbEU;wgHLG;E6*Edam&!_>GlwxuP(@9LGV0spl
zEttN=WDllgn4KZ=%#L7s88bxu1+xv9ug>BNrps9%=Im#22lF{u-N1AZD@6YcRxdFB
zDQh&Cc4i9)({tH^!1O1!C@}5M4v}BW4l(yHJ4C-Thc#HfkwXtmZ{mQs|1O6Wm@mbt
z3#Pp|A?iAy^f68+usAmtMBbXq5X{eq(u=t)!TkGNN?@9W+XPHob3@Ee<JJN5r*b=h
z=^NYzV49o90!+K{K<sbku><pu@YwKx0$KwY(4U{==1lhIQJq{P#=%~|0*-;r4!k`q
zlOG8_24c0z9>Su{V#4iW!i?L+gqd#G$h=$pBWvL{k(PJU1VX=9Et6nnm)Qt3iNW2;
G*9ibeRE-D#

delta 503
zcmcaNpR;QL=Z1}p%n|mcleaKx3$!sYFaX)9Ao`d4KfTHC88yI?QcSL3I*G{?OwVGn
z1=F{f?7_4Qvol1V*%3@HV}^*oV73AC)mePObU6#eoc%2BU_K|S8<-Aah3KEb>ILRM
zWsL^Y&TQdedM;ZKnEu2T1*ZMkA@Xb4A?E&Nhv;|aum;OFa_E8SO&k#S-{r6Z^QAa-
z!L%1AL|q4zKE~+;7U$-I$Xjz6g8BJSdNG$Jn17#32~4wan}BI+ZixA5+&W<XRBi__
zeS_NoOmp*CfN3`#i2cnxc3}Py9vdD|Kx+U4`ty_AoXP$?s*?l6IM@qVz%j7dfwzZ+
zzc|0NC^=PK!PZW}FVx3p@(Ll{=?DHXN>An$T7)jyyh5mbg%IQR6+%o>wlb51Y%Lfb
aep@SZ@e1ecUa>uaoK-PEs~Fs!e4PNP`HqSJ

diff --git a/src/RequirementChecker/Requirement.php b/src/RequirementChecker/Requirement.php
index f1ed580df..73feb9a7d 100644
--- a/src/RequirementChecker/Requirement.php
+++ b/src/RequirementChecker/Requirement.php
@@ -120,7 +120,7 @@ public static function fromArray(array $value): self
         return new self(
             RequirementType::from($value['type']),
             $value['condition'],
-            $value['source'],
+            $value['source'] ?? null,
             $value['message'],
             $value['helpMessage'],
         );
diff --git a/tests/Console/Command/InfoTest.php b/tests/Console/Command/InfoTest.php
index 60d565937..b0761d7be 100644
--- a/tests/Console/Command/InfoTest.php
+++ b/tests/Console/Command/InfoTest.php
@@ -677,18 +677,18 @@ public static function inputProvider(): iterable
                 Files Compression: None
 
                 Signature: SHA-1
-                Signature Hash: 92123D3800E1F6AD1CD1D4099B8D16BC51097A5C
+                Signature Hash: EEA3F86AA1B61484EE961055F43AA61805071CB1
 
                 Metadata: None
 
-                Timestamp: 1697988440 (2023-10-22T15:27:20+00:00)
+                Timestamp: 1699390728 (2023-11-07T20:58:48+00:00)
 
                 RequirementChecker:
                   Required:
                   - PHP >=5.3 (root)
                   - ext-phar (root)
 
-                Contents: 47 files (148.01KB)
+                Contents: 47 files (147.97KB)
 
                  // Use the --list|-l option to list the content of the PHAR.
 
diff --git a/tests/RequirementChecker/RequirementTest.php b/tests/RequirementChecker/RequirementTest.php
index 2da959c8d..f65a58889 100644
--- a/tests/RequirementChecker/RequirementTest.php
+++ b/tests/RequirementChecker/RequirementTest.php
@@ -131,6 +131,26 @@ public function test_it_can_be_created_for_a_conflicting_extension_constraint_fo
         self::assertItCanBeCreatedFromItsArrayForm($requirement, $actual);
     }
 
+    public function test_it_can_be_created_for_a_legacy_requirement(): void
+    {
+        $expected = new Requirement(
+            RequirementType::EXTENSION_CONFLICT,
+            'mbstring',
+            null,
+            'The package "box/test" conflicts with the extension "mbstring".',
+            'The package "box/test" conflicts with the extension "mbstring". You need to disable it in order to run this application.',
+        );
+
+        $actual = Requirement::fromArray([
+            'type' => 'extension-conflict',
+            'condition' => 'mbstring',
+            'message' => 'The package "box/test" conflicts with the extension "mbstring".',
+            'helpMessage' => 'The package "box/test" conflicts with the extension "mbstring". You need to disable it in order to run this application.',
+        ]);
+
+        self::assertEquals($expected, $actual);
+    }
+
     private static function assertItCanBeCreatedFromItsArrayForm(Requirement $expected, array $arrayForm): void
     {
         $actual = Requirement::fromArray($arrayForm);