From 21fb7c7fd698bcb0ed2a20c1f53e1b6e2956c84a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Th=C3=A9o=20FIDRY?= <5175937+theofidry@users.noreply.github.com> Date: Sun, 26 Nov 2023 10:50:15 +0100 Subject: [PATCH] ci: Disable the PR-main benchmark comparison (#1212) To enable back once generating the report file is figured out. --- .github/workflows/benchmark.yaml | 82 ++++++++++++++++---------------- 1 file changed, 42 insertions(+), 40 deletions(-) diff --git a/.github/workflows/benchmark.yaml b/.github/workflows/benchmark.yaml index 93504b116..a8609089b 100644 --- a/.github/workflows/benchmark.yaml +++ b/.github/workflows/benchmark.yaml @@ -87,45 +87,47 @@ jobs: - name: Run PHPBench run: make phpbench - pr-main-bench-test: - runs-on: ubuntu-latest - name: Benchmark PR compared to main - needs: main-bench-test - steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 - - - name: Setup PHP - uses: shivammathur/setup-php@v2 - with: - php-version: '8.2' - ini-values: phar.readonly=0, display_errors=On, error_reporting=-1 - tools: composer - coverage: none - - - name: Install Composer dependencies - uses: ramsey/composer-install@v2 - - - name: Ensure that the make target is up to date - run: make _vendor_install - - - name: Install PHPBench - uses: ramsey/composer-install@v2 - with: - working-directory: vendor-bin/phpbench - - - name: Ensure that the PHPBench make target is up to date - run: make phpbench_install - - - name: Download the Benchmark results of the main branch - uses: actions/download-artifact@v3 - with: - name: bench-branch-main-result - - - name: Run PHPBench for PR branch - run: make phpbench_pr +# TODO: to enable back once figured out how to make it work. For some reasons no file report is created so +# no comparison is possible. +# pr-main-bench-test: +# runs-on: ubuntu-latest +# name: Benchmark PR compared to main +# needs: main-bench-test +# steps: +# - name: Checkout +# uses: actions/checkout@v4 +# with: +# fetch-depth: 0 +# +# - name: Setup PHP +# uses: shivammathur/setup-php@v2 +# with: +# php-version: '8.2' +# ini-values: phar.readonly=0, display_errors=On, error_reporting=-1 +# tools: composer +# coverage: none +# +# - name: Install Composer dependencies +# uses: ramsey/composer-install@v2 +# +# - name: Ensure that the make target is up to date +# run: make _vendor_install +# +# - name: Install PHPBench +# uses: ramsey/composer-install@v2 +# with: +# working-directory: vendor-bin/phpbench +# +# - name: Ensure that the PHPBench make target is up to date +# run: make phpbench_install +# +# - name: Download the Benchmark results of the main branch +# uses: actions/download-artifact@v3 +# with: +# name: bench-branch-main-result +# +# - name: Run PHPBench for PR branch +# run: make phpbench_pr # This is a "trick", a meta task which does not change, and we can use in @@ -137,7 +139,7 @@ jobs: needs: - main-bench-test - pr-bench-test - - pr-main-bench-test +# - pr-main-bench-test if: always() steps: - name: Successful run