From 186f264e90c0d8c03e7eb03d984f8cf214ca5969 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Th=C3=A9o=20FIDRY?= <5175937+theofidry@users.noreply.github.com> Date: Sun, 19 Nov 2023 14:00:24 +0100 Subject: [PATCH] test(requirement-checker): Fix the requirement checker e2e tests (#1178) --- .../fail-complete/expected-boxmin-stderr.dist | 11 ++++------- .../fail-complete/expected-composermin-stderr.dist | 6 +++--- .../fail-conflict/expected-boxmin-stderr.dist | 8 ++++---- .../pass-complete/expected-boxmin-stderr.dist | 4 ++-- .../pass-complete/expected-composermin-stderr.dist | 4 ++-- 5 files changed, 15 insertions(+), 18 deletions(-) diff --git a/requirement-checker/fixtures/fail-complete/expected-boxmin-stderr.dist b/requirement-checker/fixtures/fail-complete/expected-boxmin-stderr.dist index fe4c3e9df..46afb7ccd 100644 --- a/requirement-checker/fixtures/fail-complete/expected-boxmin-stderr.dist +++ b/requirement-checker/fixtures/fail-complete/expected-boxmin-stderr.dist @@ -6,11 +6,11 @@ Box Requirements Checker > PHP is not using any php.ini file. > Checking Box requirements: - ✘ The application requires a version matching "^10". - ✔ The application requires the extension "phar". + ✘ This application requires a PHP version matching "^10". + ✔ This application requires the extension "phar". ✔ The package "package-with-extensions" requires the extension "json". ✘ The package "package-with-extensions" requires the extension "ldap". - ✘ The package "package-with-extensions" requires the extension "random". + ✔ The package "package-with-extensions" requires the extension "random". [ERROR] Your system is not ready to run the application. @@ -19,11 +19,8 @@ Box Requirements Checker Fix the following mandatory requirements: ========================================= - * The application requires a version matching "^10". + * This application requires a PHP version matching "^10". * The package "package-with-extensions" requires the extension "ldap". You either need to enable it or request the application to be shipped with a polyfill for this extension. - * The package "package-with-extensions" requires the extension "random". You - either need to enable it or request the application to be shipped with a - polyfill for this extension. diff --git a/requirement-checker/fixtures/fail-complete/expected-composermin-stderr.dist b/requirement-checker/fixtures/fail-complete/expected-composermin-stderr.dist index 93f698f50..1dd77286c 100644 --- a/requirement-checker/fixtures/fail-complete/expected-composermin-stderr.dist +++ b/requirement-checker/fixtures/fail-complete/expected-composermin-stderr.dist @@ -6,8 +6,8 @@ Box Requirements Checker > PHP is not using any php.ini file. > Checking Box requirements: - ✘ The application requires a version matching "^10". - ✔ The application requires the extension "phar". + ✘ This application requires a PHP version matching "^10". + ✔ This application requires the extension "phar". ✔ The package "package-with-extensions" requires the extension "json". ✘ The package "package-with-extensions" requires the extension "ldap". ✘ The package "package-with-extensions" requires the extension "random". @@ -19,7 +19,7 @@ Box Requirements Checker Fix the following mandatory requirements: ========================================= - * The application requires a version matching "^10". + * This application requires a PHP version matching "^10". * The package "package-with-extensions" requires the extension "ldap". You either need to enable it or request the application to be shipped with a polyfill for this extension. diff --git a/requirement-checker/fixtures/fail-conflict/expected-boxmin-stderr.dist b/requirement-checker/fixtures/fail-conflict/expected-boxmin-stderr.dist index 5977bdcf8..e2640d72a 100644 --- a/requirement-checker/fixtures/fail-conflict/expected-boxmin-stderr.dist +++ b/requirement-checker/fixtures/fail-conflict/expected-boxmin-stderr.dist @@ -6,8 +6,8 @@ Box Requirements Checker > PHP is not using any php.ini file. > Checking Box requirements: - ✔ The application requires the extension "phar". - ✘ The application conflicts with the extension "pdo". + ✔ This application requires the extension "phar". + ✘ This application conflicts with the extension "pdo". [ERROR] Your system is not ready to run the application. @@ -16,6 +16,6 @@ Box Requirements Checker Fix the following mandatory requirements: ========================================= - * The application conflicts with the extension "pdo". You need to disable it in - order to run this application. + * This application conflicts with the extension "pdo". You need to disable it + in order to run this application. diff --git a/requirement-checker/fixtures/pass-complete/expected-boxmin-stderr.dist b/requirement-checker/fixtures/pass-complete/expected-boxmin-stderr.dist index 0d9258c06..9a245fd08 100644 --- a/requirement-checker/fixtures/pass-complete/expected-boxmin-stderr.dist +++ b/requirement-checker/fixtures/pass-complete/expected-boxmin-stderr.dist @@ -6,8 +6,8 @@ Box Requirements Checker > PHP is not using any php.ini file. > Checking Box requirements: - ✔ The application requires a version matching ">=5.3". - ✔ The application requires the extension "phar". + ✔ This application requires a PHP version matching ">=5.3". + ✔ This application requires the extension "phar". [OK] Your system is ready to run the application. diff --git a/requirement-checker/fixtures/pass-complete/expected-composermin-stderr.dist b/requirement-checker/fixtures/pass-complete/expected-composermin-stderr.dist index 0d9258c06..9a245fd08 100644 --- a/requirement-checker/fixtures/pass-complete/expected-composermin-stderr.dist +++ b/requirement-checker/fixtures/pass-complete/expected-composermin-stderr.dist @@ -6,8 +6,8 @@ Box Requirements Checker > PHP is not using any php.ini file. > Checking Box requirements: - ✔ The application requires a version matching ">=5.3". - ✔ The application requires the extension "phar". + ✔ This application requires a PHP version matching ">=5.3". + ✔ This application requires the extension "phar". [OK] Your system is ready to run the application.