Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart is not the same size! #100

Open
elcolie opened this issue Nov 24, 2017 · 6 comments
Open

Chart is not the same size! #100

elcolie opened this issue Nov 24, 2017 · 6 comments

Comments

@elcolie
Copy link

elcolie commented Nov 24, 2017

image

I need to change from 1.6 to 1.4
"react-sparklines": "^1.6.0",

Solution: Back to old version
"react-sparklines": "1.4.0",

@lavebug
Copy link

lavebug commented Nov 27, 2017

Same thing here. Switching to "react-sparklines": "1.4.0" did not help. Welp

screen shot 2017-11-27 at 10 06 14 am

@elcolie
Copy link
Author

elcolie commented Nov 28, 2017

@lavebug Do you use the npm and node like mine?

rifle:weather sarit$ npm -version
5.5.1
rifle:weather sarit$ node --version
v9.2.0

And also do not forget to remove node_moduels stuff before install the packages again.
Here is my package.json

{
  "name": "redux-simple-starter",
  "version": "1.0.0",
  "description": "Simple starter package for Redux with React and Babel support",
  "main": "index.js",
  "repository": "[email protected]:StephenGrider/ReduxSimpleStarter.git",
  "scripts": {
    "start": "node ./node_modules/webpack-dev-server/bin/webpack-dev-server.js",
    "test": "mocha --compilers js:babel-core/register --require ./test/test_helper.js --recursive ./test",
    "test:watch": "npm run test -- --watch"
  },
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "babel-core": "^6.2.1",
    "babel-loader": "^6.2.0",
    "babel-preset-es2015": "^6.1.18",
    "babel-preset-react": "^6.1.18",
    "chai": "^3.5.0",
    "chai-jquery": "^2.0.0",
    "jquery": "^2.2.1",
    "jsdom": "^8.1.0",
    "mocha": "^2.4.5",
    "react-addons-test-utils": "^0.14.7",
    "webpack": "^1.12.9",
    "webpack-dev-server": "^1.14.0"
  },
  "dependencies": {
    "axios": "^0.17.1",
    "babel-preset-stage-1": "^6.1.18",
    "lodash": "^3.10.1",
    "react": "^0.14.3",
    "react-dom": "^0.14.3",
    "react-redux": "4.3.0",
    "react-router": "^2.0.1",
    "react-sparklines": "1.4.0",
    "redux": "^3.0.4",
    "redux-promise": "^0.5.3"
  }
}

@lavebug
Copy link

lavebug commented Nov 28, 2017

Got it working with "react-sparklines": "1.4.0" somehow npm install was ignoring version reswtarted my macbook pro run npm install again bam works.

@rickytorrez
Copy link

Yeah, also got it working with version '1.4.0'.
I went into my node_modules folder and deleted 'react-sparklines' folder as well as into 'package.json'.
Re-installed version 1.4.0 on the terminal.
Quit the server and re-run again.

@kmoreti
Copy link

kmoreti commented Jun 8, 2018

If needed, just add to /style/style.css the following:
svg {
height: 150px;
}

@kshimauchi
Copy link

I like kmoreti, answer the best. I tried multiple versions of the 'react-sparklines' 1.4-1.6, give me an error of undefined string in the bundle.js, while 1.7 version works without this error. The error I believe has something to do with the color property of the graph. That being said the simplest fix was adding the style above lol!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants