Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup fails when empty "exclude if present" is added to the list #2135

Open
2 tasks done
deermo opened this issue Nov 15, 2024 · 3 comments · May be fixed by #2136
Open
2 tasks done

Backup fails when empty "exclude if present" is added to the list #2135

deermo opened this issue Nov 15, 2024 · 3 comments · May be fixed by #2136
Labels
type:bug Something doesn't work as intended

Comments

@deermo
Copy link

deermo commented Nov 15, 2024

Description

Not sure how it got there, but I just had an empty item in the "Exclude if present" list. I realized this as my backup finished after a few seconds without error.

The log shows:
Running command /Applications/Vorta.app/Contents/Resources/borg-dir/borg.exe create --list --progress --info --log-json --json --filter=AM -C lz4 --patterns-from=/Users/mo/Backup/excludes/borg_excl_patterns.lst --exclude-if-present .nobackup --exclude-if-present ssh://PATH-TO-ARCHIVE /BACKUP/PATH

The issue seems to be that an empty "--exclude-if-present" is passed to borg and probably the rest of the command gets broken.

Reproduction

  • I tried to reproduce the issue.
  • I was able to reproduce the issue.

OS

macOS 15.1 (24B83)

Version of Vorta

0.10.1

What did you install Vorta with?

Binary

Version of Borg

1.4.0

Logs

See above
@m3nu m3nu added the type:bug Something doesn't work as intended label Nov 15, 2024
@m3nu
Copy link
Contributor

m3nu commented Nov 15, 2024

What do you see in your Exclude if Present dialog? Just checked the code and not sure how this could be empty. Of course we can add another check anyways.

@m3nu m3nu linked a pull request Nov 15, 2024 that will close this issue
@m3nu
Copy link
Contributor

m3nu commented Nov 15, 2024

Can you check if

@goebbe
Copy link

goebbe commented Nov 19, 2024

@deermo Did you define the "exclude if present" using Vortas "Manage Exclude Items"?
Source>Mangage Exluded Items>Exclude If Present
The only way I could get this behaviour, using Vorta, is by at least putting one space " ", when adding a new "exclude if present" pattern. Without whitespace, no empty "exclude if present" pattern seems to be created anyway.
@m3nu I cannot test, right now - but the proposed change should indeed fix the issue, since, with the fix, the "exclude-if-present" is not created if the pattern contains only whitespace.

Sidenote: It is also possible to create custom exclude patterns with only whitespace " " in the "Custom" tab - but I guess in this case an empty (only whitespace) line in the --exclude-from file does not have unintended side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something doesn't work as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants