-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Search a file in diff and extract view #1674
Comments
Instead of these options we could support the python regex syntax. |
Yes, and an explicit search button instead of the currently implied live reload (or an enter press) would be better UX. A popup for advanced search keeps it simple by default and powerful when needed. Advanced Search - Where we can have multiple fields together instead of searching by just one field, and changing the field to search again (which does not help cases where multiple filters should be taken into account simultaneously). Regex support will solve all problems related to names and strings, while the advanced search popup could do this for numeric and complex filters (dates/sizes/etc.) |
The idea was to have a syntax similar to the search feature on github. E.g. |
I think the dialog would be easier to use without referring to documentation (supported keywords) of any kind, but this works as well. |
You are right. Would the dialog be open alongside the diff view while sorting or will there be an |
Yes, will help in changing the values faster.
I personally like clicking buttons or pressing keys more than seeing changes live. So I would prefer an apply button that would close it. This will also solve the cluttering problem as it will just add an Whenever a value is given to the dialog for a particular filter, it would append it to the search bar according to the search syntax, and consecutive changes (probably smaller shifts in value), would be quicker to make. |
Just an idea but I think we could also do something like: " |
Sounds a bit complex, but yes, maybe a mockup will make your point clearer. |
I guess yes, I'll get the mockup done as soon as possible. |
If search field already consists filters like |
That's a thing, but the separated view will make it easier to look at all the selected filter tags and edit them, instead of scrolling left-right to find the tag and the value if there are a lot of filter or a long value or attribute. |
That's a good idea. |
The problem
For discussion regarding
https://github.com/borgbase/vorta/wiki/Google-Summer-of-Code-2023-Ideas#search-a-file-in-diff-and-extract-view
TLDR; There's currently no option to filter/search items in diff or extract. This FR aims to add this function.
Requested Solution
Initially proposed GUI:
After suggestions from @m3nu and @real-yfprojects, removed the additional filter options as it gets too cluttered.
New design:
and a dropdown which automatically adds supported search syntax.
Syntax for search pattern:
The text was updated successfully, but these errors were encountered: