Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings for rejecting WIFIs by default and for showing WIFI not allowed messages. #1655

Open
real-yfprojects opened this issue Mar 16, 2023 Discussed in #1654 · 3 comments · May be fixed by #1658
Open

Settings for rejecting WIFIs by default and for showing WIFI not allowed messages. #1655

real-yfprojects opened this issue Mar 16, 2023 Discussed in #1654 · 3 comments · May be fixed by #1658
Assignees
@diivi
Labels
good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it type:enhancement Improvement of an existing function

Comments

@real-yfprojects
Copy link
Collaborator

Add two settings called something along the lines of Allow WiFis by default and Show notification when WiFi is disallowed.

Discussed in #1654

Originally posted by bcelary March 16, 2023
My Vorta runs daily backups when I am at home to my local NAS server. But I often move around and any other WiFi should not be used to even attempt a backup.

Would you consider adding an option that would require user to explicitly add a WiFi to allowed networks? Especially when using local address (like 192.168... or host.local name)? Also the message that WiFi is not allowed might become a non-error message, as Vorta keeps nagging me all the time when I am away from home.

These options could be added in the Networks panel, here:
image

E.g. x Don't allow new WiFi connections and x silence "cuurent WiFi is not allowed" messages.

Asking if such idea makes sense as this seems like something easy to add and I might as well create a PR for this.
@real-yfprojects real-yfprojects added type:enhancement Improvement of an existing function good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it labels Mar 16, 2023
@diivi
Copy link
Contributor

diivi commented Mar 16, 2023 •
edited
Loading

Ah, I didn't know vorta allowed every network you connected to by default. @bcleary I'd be happy to work on this for/with you, I'm trying to learn more about the project. Thanks!

@diivi
Copy link
Contributor

diivi commented Mar 16, 2023

@real-yfprojects You can assign this to me, I have an approach ready.

@diivi diivi linked a pull request Mar 17, 2023 that will close this issue
Open
9 tasks
@bcelary
Copy link

bcelary commented Mar 19, 2023

wow, things move really fast in here! thank you @diivi 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diivi diivi

Labels
good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it type:enhancement Improvement of an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: settings to allow new networks and show notif when a network is disallowed diivi/vorta
3 participants
@bcelary @diivi @real-yfprojects