Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor check box and radio button helpers #547

Open
lcreid opened this issue Oct 20, 2019 · 2 comments
Open

Refactor check box and radio button helpers #547

lcreid opened this issue Oct 20, 2019 · 2 comments
Labels
Bootstrap 5

Comments

@lcreid
Copy link
Contributor

lcreid commented Oct 20, 2019

One approach to solving #477 and related issues would be to implement be to make our implementation use the Rails methods for label and check_box and radio_button in a way that would make our helpers easier to use in the collection helpers.
@lcreid lcreid self-assigned this Oct 20, 2019
@lcreid
Copy link
Contributor Author

lcreid commented Oct 20, 2019

It looks like the Rails internals use string keys, and we use symbol keys. This could be causing all sorts of unexpected behaviour, and could require all sorts of extra code.

@lcreid
Copy link
Contributor Author

lcreid commented Jun 20, 2020

Added the Bootstrap 5 label because we should take a look at this if we're making changes to the fundamental code.

@lcreid lcreid removed their assignment Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bootstrap 5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lcreid