From 65fbfd4301aae158d7dea2ea08d212e4444a7176 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexis=20Lothor=C3=A9?= Date: Fri, 1 Dec 2023 14:02:29 +0100 Subject: [PATCH] debugging: labs: replace $< with $^ in system_profiling lab Makefile MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit While both $< and $^ are valid to manipulate a single prerequisite in a makefile target, it can lead to silent issue when updating the makefile. For example, we need to add the tracepoint provider generated object at some point in the final binary, and it is very likely that both trainer and trainees will forget to update this symbol to take all prerequisites instead of only the first one, if they do not copy-paste directly the makefile sample given in labs instruction Prevent this omision by using directly $^ in base Makefile for system profiling lab. Signed-off-by: Alexis Lothoré --- lab-data/debugging/nfsroot/root/system_profiling/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lab-data/debugging/nfsroot/root/system_profiling/Makefile b/lab-data/debugging/nfsroot/root/system_profiling/Makefile index 369ef509d3..5470be4cbb 100644 --- a/lab-data/debugging/nfsroot/root/system_profiling/Makefile +++ b/lab-data/debugging/nfsroot/root/system_profiling/Makefile @@ -1,4 +1,4 @@ export CC=${CROSS_COMPILE}gcc crc_random: crc_random.c - ${CC} $< -g3 -o $@ + ${CC} $^ -g3 -o $@