Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost.sort header conflicts with boost.range header #126

Open
BenFrantzDale opened this issue Mar 25, 2021 · 1 comment
Open

boost.sort header conflicts with boost.range header #126

BenFrantzDale opened this issue Mar 25, 2021 · 1 comment

Comments

@BenFrantzDale
Copy link
Contributor

BenFrantzDale commented Mar 25, 2021

See https://svn.boost.org/trac10/ticket/11202 which seems to be abandoned.

In boost/range/algorithm/sort.hpp (https://github.com/boostorg/range/blob/develop/include/boost/range/algorithm/sort.hpp#L65) there's

    } // namespace range
    using range::sort;
} // namespace boost

which pollutes the ::boost namespace with sort. But ::boost::sort is a namespace used here: https://github.com/boostorg/sort/blob/develop/include/boost/sort/heap_sort/heap_sort.hpp#L25

This means I can't use both boost::sort and boost::range::sort.

This appears to violate https://svn.boost.org/trac10/wiki/Guidelines/MaintenanceGuidelines#Avoidtheinclusionofsymbolsattheboostorboost::detailnamespace

@olologin
Copy link

Please fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants