Fixed int -> float truncation warning in pixel.hpp #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying channel type for grayscale pixels is a 32-bit float. If `Channel` cannot be losslessly converted to a float--for example, if it is `int`--this would generate a compiler warning. The fix here is to perform an explicit cast. Fixes boostorg#688.
|
The proposed change fixes the warning for the sample code given, but fails template instantiation for pixels that have a raw channel type (i.e., that don't use Also, on further inspection I'm not sure that a simple cast is even warranted here--the warning in #688 results from a piece of code in numeric.hpp that's multiplying 2 shorts (producing an int) and then assigning it to a 32-bit float grayscale pixel (which is scoped to [0, 1]). I'm not sure what the correct behaviour even is there, so I'll close this and let someone more knowledgeable figure this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The underlying channel type for grayscale pixels is a 32-bit float. If
Channelcannot be losslessly converted to a float--for example, if it isint--this would generate a compiler warning. The fix here is to perform an explicit cast. Fixes #688.References
See related issue: #688.