Move useMemo out of an if

bonafideduck · Jul 16, 2022 · 3318a2c · 3318a2c
1 parent bc231a6
commit 3318a2c
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/HighlightWithinTextarea.tsx b/src/HighlightWithinTextarea.tsx
@@ -108,12 +108,12 @@ const HighlightWithinTextarea = React.forwardRef<Editor, HWTAProps>(
 
     const contentState = editorState.getCurrentContent();
     let decorator;
-    if (highlight) {
-      decorator = useMemo(
-        () => createDecorator(contentState, highlight as Highlight, value),
-        [contentState, highlight, value]
-      );
-    }
+    decorator = useMemo(
+      () =>
+        highlight &&
+        createDecorator(contentState, highlight as Highlight, value),
+      [contentState, highlight, value]
+    );
 
     editorState = EditorState.set(editorState, {
       decorator: decorator,
@@ -149,7 +149,7 @@ const HighlightWithinTextarea = React.forwardRef<Editor, HWTAProps>(
     delete newProps.selection;
     delete newProps.placeholder;
     delete newProps.onChange;
-    delete (newProps as {value?: string}).value;
+    delete (newProps as { value?: string }).value;
 
     return (
       <Editor