fix: Potential race for file access in DotTest #249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears like CI runs for
DotTest
fail non-deterministically. See recent runs of the coverage CI:While I can't reproduce this locally, my suspicion is that multiple tests use
"./test.dot"
simultaneously, which then causes race conditions or file access conflicts due to concurrent write/read attempts to the same file path.This PR provides a fix by making the filenames unique (683ed98).
f826ab6 increases cross-platform compatibility and should be unrelated to this issue.