Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliver workarounds to Gutenberg issues as PRs and tidy Fizzie when implemented #25

Closed
bobbingwide opened this issue Nov 8, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Nov 8, 2020

To date I've developed local workarounds for a number of issues found in Gutenberg's experimental Full Site Editing solutions.
I summarised the local improvements that I've made so far in #18.

Requirements

In the long term I'd want to see these problems addressed in Gutenberg / WordPress core.
When this has been done, there should be no need for the local workaround.
This issue is to track issues and PRs as they progress through Gutenberg
then to remove the local workaround when it's no longer necessary.

Proposed solution

  • Raise a Gutenberg issue for each problem
  • Implement a PR to fix the issue.
  • Remove the local change when the PR's been merged, or otherwise fixed.

THIS TABLE IS WELL OUT OF DATE - 2022/01/12

Area Fizzie issue Gutenberg issue Gutenberg PR(s) Merged? Removed from Fizzie
core/template-part #1 WordPress/gutenberg#26010 WordPress/gutenberg#26772
core/post-excerpt mentioned in #18 WordPress/gutenberg#26581 WordPress/gutenberg#26806 ( replaces 26785 ) 9.4
core/query-pagination #18 WordPress/gutenberg#26557 ( pre-existing ) WordPress/gutenberg#26831
core/query-loop #11 WordPress/gutenberg#25377 (pre-existing) WordPress/gutenberg#26825
core/template-part postId #1 (comment) WordPress/gutenberg#26734 WordPress/gutenberg#26812
core/template-part wpautop() #20 WordPress/gutenberg#26731 WordPress/gutenberg#26809
core/post-content #7 WordPress/gutenberg#26593 WordPress/gutenberg#26807
core/post-hierarchical-terms #29 WordPress/gutenberg#26851 WordPress/gutenberg#26854 9.4
core/post-content #27 WordPress/gutenberg#26923 WordPress/gutenberg#27012
core/navigation-link #22 site_url part
core/navigation #22 current-menu-item part
@bobbingwide bobbingwide added the enhancement New feature or request label Nov 8, 2020
@bobbingwide bobbingwide self-assigned this Nov 8, 2020
bobbingwide added a commit that referenced this issue Nov 13, 2020
…fixed using the editor. Issue #25 - start refactoring of overrides
bobbingwide added a commit that referenced this issue Nov 15, 2020
@bobbingwide
Copy link
Owner Author

bobbingwide commented Jan 12, 2022

For Fizzie v1.0.0 I've commented out the logic that's no longer needed, but not yet removed it.
I've also updated the logic so that the remaining overrides are applied when Gutenberg is not activated.
This caters for sites which have WordPress 5.9; the first version where Gutenberg is not required for an FSE theme.

@bobbingwide
Copy link
Owner Author

Closing this issue. I no longer intend raising PRs against Gutenberg. But look forward to when I no longer feel the need to override block rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant