Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Verification for correct transfer of Satoshi in Ordinal Marketplace #170

Open
nakul1010 opened this issue Feb 19, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@nakul1010
Copy link
Contributor

Problem:
In the Ord_Marketplace.sol -> proofOrdinalSellOrder() method, there is a lack of verification for the correct transfer of the satoshi to the buyer's address. While the contract checks that the transaction is spending the specified UTXO and has an output to the buyer's address, it does not verify which specific satoshi is being transferred. This loophole allows potential cheating in the demo version.

Solution:

Implement additional verification steps within the proofOrdinalSellOrder() method to ensure the correct transfer of the specific satoshi to the buyer's address. This includes validating the exact satoshi being transferred and verifying it against the provided UTXO and offset information. By enhancing this method with precise verification checks, the contract can prevent potential cheating and ensure the secure transfer of satoshis in the marketplace.

Originally posted by @sander2 in #114 (comment)

@nakul1010 nakul1010 added the bug Something isn't working label Feb 19, 2024
@nud3l nud3l added this to Backlog Feb 19, 2024
@github-project-automation github-project-automation bot moved this to New 🆕 in Backlog Feb 19, 2024
@gregdhill gregdhill removed this from Backlog Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant