Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Mnemonic seeds and keys are not handled securely #54

Open
who-biz opened this issue May 16, 2019 · 0 comments
Open

Enhancement: Mnemonic seeds and keys are not handled securely #54

who-biz opened this issue May 16, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request fast-track Enhancements that need treated as important, just behind bugs in priority. under investigation

Comments

@who-biz
Copy link
Contributor

who-biz commented May 16, 2019

Since our mnemonic seed is a representation of the private spendkey, we should take better care to ensure that it is not trivially read from some plain-text source. This issue was raised by a member of our Telegram chat.

We should be using some secure storage mechanism (like that which libhydrogen provides for stored representations of passwords, for example) to protect users from phishing attacks.

We should also avoid displaying the key as a default behavior. Giving users a choice to display key, or even using something like GPGme to securely store the key in a file, or something, would probably be better.

@who-biz who-biz changed the title Mnemonic seeds and keys are not handled securely Enhancement: Mnemonic seeds and keys are not handled securely May 16, 2019
@who-biz who-biz self-assigned this May 16, 2019
@who-biz who-biz added enhancement New feature or request fast-track Enhancements that need treated as important, just behind bugs in priority. under investigation labels May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fast-track Enhancements that need treated as important, just behind bugs in priority. under investigation
Projects
None yet
Development

No branches or pull requests

1 participant