You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not liking the things in that library. Historically, its been a source of a fairly large problem at least once (Cisco Talos). Comments in code don't seem to be happy with it either... which draws similar attention to p2p.
IP addressess handled irresponsibly...
Removed a gif-content-type from the http_base.h header file
For some reason we have code that handles all kinds of media/web files (?)
-
who-biz
changed the title
Enhancement: (partial, at least) rewrite of epee library
Enhancement: rewrite of epee library (partial, at least)
Apr 21, 2019
epee namespace appears to be using ssize_t everywhere std::size_t occurs. since size_t is not always portable, this could be the reason... but can we need to make sure that std::size_t should indeed be a ssize_t as compiler says ... or, if it should be a size_t as name implies... we should make this clearer.
Other places this was occurring, as far as the linker was concerned:
src/checkpoints/checkpoints.cpp
external/easylogging.h
contrib/epee/include/misc_log_ex.h
src/crypto & src/crypto/crypto-ops in various files
Similarly, there is a special case going on with streams. If this is simply for portability -- great. No problems. But make the customized types less confusing
Something found when building the snap for v0.1.9.6 (snapcraft core uses ubuntu:16.04)
Definitely worth looking into what exactly is going on here... as it may be the cause of some of the p2p oddities, and looks to have the ability to affect everything that uses endpoint addresses.
Not liking the things in that library. Historically, its been a source of a fairly large problem at least once (Cisco Talos). Comments in code don't seem to be happy with it either... which draws similar attention to p2p.
http_base.h
header file-
blur/contrib/epee/include/net/http_protocol_handler.inl
Lines 663 to 688 in 8fa4725
Consider partial rewrite.
The text was updated successfully, but these errors were encountered: