-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing target countries #93
base: master
Are you sure you want to change the base?
Conversation
Some countries were missing from the list of possible target countries of the Google Shopping Content API. This commit uses the list available at https://support.google.com/merchants/answer/160637.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
Please updated the PR with the needed changes, then I'll merge it.
<currency_name>Saudi Riyal</currency_name> | ||
</SA> | ||
<SG translate="name currency_name"> | ||
<name>South Africa</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the country name should be Singapur
<currency>CHF</currency> | ||
<currency_name>Swiss Franc</currency_name> | ||
</CH> | ||
<TH translate="name currency_name"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tag should be TW not TH
<currency>ZAR</currency> | ||
<currency_name>South African Rand</currency_name> | ||
</ZA> | ||
<ES translate="name currency_name"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
South Korea is missing
Hello,
Some countries were missing from the list of possible target countries of the Google Shopping Content API. This commit uses the list available at https://support.google.com/merchants/answer/160637.
Thank you,
Ricardo Velhote