Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing target countries #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rvelhote
Copy link

@rvelhote rvelhote commented Feb 8, 2018

Hello,

Some countries were missing from the list of possible target countries of the Google Shopping Content API. This commit uses the list available at https://support.google.com/merchants/answer/160637.

Thank you,
Ricardo Velhote

Some countries were missing from the list of possible target countries
of the Google Shopping Content API. This commit uses the list available
at https://support.google.com/merchants/answer/160637.
Copy link
Contributor

@schnere schnere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!
Please updated the PR with the needed changes, then I'll merge it.

<currency_name>Saudi Riyal</currency_name>
</SA>
<SG translate="name currency_name">
<name>South Africa</name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the country name should be Singapur

<currency>CHF</currency>
<currency_name>Swiss Franc</currency_name>
</CH>
<TH translate="name currency_name">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag should be TW not TH

<currency>ZAR</currency>
<currency_name>South African Rand</currency_name>
</ZA>
<ES translate="name currency_name">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

South Korea is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants