You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello! Working on getting a Docker image built over in StaPH-B/docker-builds#816 and noticed this during compilation:
#10 50.29 Compiling sylph v0.4.1 (/sylph-0.4.1)
#10 50.84 warning: call to `.clone()` on a reference in this situation does nothing
#10 50.84 --> src/contain.rs:485:47
#10 50.84 |
#10 50.84 485 | let file = File::open(read_sketch_file.clone()).expect(&format!(
#10 50.84 | ^^^^^^^^ help: remove this redundant call
#10 50.84 |
#10 50.84 = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
#10 50.84 = note: `#[warn(noop_method_call)]` on by default
Is this something we need to be concerned with? cc @erinyoung
The text was updated successfully, but these errors were encountered:
Hello! Working on getting a Docker image built over in StaPH-B/docker-builds#816 and noticed this during compilation:
Is this something we need to be concerned with? cc @erinyoung
The text was updated successfully, but these errors were encountered: