Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alt-tags key naming #179

Closed
xynydev opened this issue May 11, 2024 · 2 comments
Closed

alt-tags key naming #179

xynydev opened this issue May 11, 2024 · 2 comments
Labels
type: discussion Questions, proposals and info that requires discussion.

Comments

@xynydev
Copy link
Member

xynydev commented May 11, 2024

My mental model of this configuration option was "the default is latest+timestamp, but you can override if you want to", while the alt-tags: name sounds more like "latest+timestamp is the recommended way to tag, but you can swap it out for an alternative method". I'll make an issue about this too.

image-tags: was the name I originally suggested for this key, but I understand that might be confusing, as we also have image-version:.

What do y'all think?

@xynydev xynydev added the type: discussion Questions, proposals and info that requires discussion. label May 11, 2024
@xynydev xynydev mentioned this issue May 11, 2024
8 tasks
@gmpinder
Copy link
Member

To be completely honest, I came up with that name without going back to the original thread. Now that you brought it up, I don't think image-tags: would have been clear enough. Since we haven't released official documentation for this property, I'm fine with renaming it to something else.

@gmpinder
Copy link
Member

After conversations on discord, we're going to keep this as alt-tags for now and just proceed with working on recipe V2 (#180)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: discussion Questions, proposals and info that requires discussion.
Projects
None yet
Development

No branches or pull requests

2 participants