Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show local time on charts without candle duplication during DST #73

Open
bludnic opened this issue Nov 12, 2024 · 2 comments
Open

Show local time on charts without candle duplication during DST #73

bludnic opened this issue Nov 12, 2024 · 2 comments
Assignees
Labels
bug Something isn't working ui

Comments

@bludnic
Copy link
Owner

bludnic commented Nov 12, 2024

The previous solution, which involved modifying the date directly, caused a duplicate candle issue during the DST transition. Rolled back the changes. Now the time is in UTC regardless of the client timezone.

https://github.com/bludnic/opentrader-pro/commit/149f45d5abff329b8abef3f7cb6a2cb97e965a3c

@bludnic bludnic added bug Something isn't working ui labels Nov 12, 2024
@bludnic bludnic self-assigned this Nov 12, 2024
@bludnic
Copy link
Owner Author

bludnic commented Nov 12, 2024

Covered the duplicate candle scenario with tests (currently failing until the fix arrives):

https://github.com/bludnic/opentrader-pro/blob/149f45d5abff329b8abef3f7cb6a2cb97e965a3c/frontend/src/utils/charts/timeToLocal.test.ts

Note: The tests should pass for different timezones including UTC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui
Projects
None yet
Development

No branches or pull requests

1 participant