You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The event in acceptSwap is logging the allowed variable from the swap struct, which might be the address 0 in case the swap is open to the public, and the user who accepted will not be present in the log - address(0) will be instead - making it impossible to query the swap using his address when connected to the dApp.
Expected behavior
We expect that the acceptSwap emits the msg.sender instead of allowed so we can correctly query the user who accepted the swap.
Definition of Done:
Change allowed for msg.sender
Correct the tests that will fail subsequently
Related code
emit SwapAccepted(swapId, swap.owner, allowed);
The text was updated successfully, but these errors were encountered:
Bug Report
Current behavior
The event in
acceptSwap
is logging theallowed
variable from the swap struct, which might be the address 0 in case the swap is open to the public, and the user who accepted will not be present in the log - address(0) will be instead - making it impossible to query the swap using his address when connected to the dApp.Expected behavior
We expect that the
acceptSwap
emits themsg.sender
instead ofallowed
so we can correctly query the user who accepted the swap.Definition of Done:
allowed
formsg.sender
Related code
The text was updated successfully, but these errors were encountered: