Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store pubkey on its own table #222

Open
3 tasks
pikonha opened this issue Oct 7, 2024 · 0 comments
Open
3 tasks

store pubkey on its own table #222

pikonha opened this issue Oct 7, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@pikonha
Copy link
Contributor

pikonha commented Oct 7, 2024

Feature Request

Since ENS doesn't have the concept of reserved keys on the texts table, we need to decouple the pubkey from the texts table.

Describe Preferred Solution

  • Create a pubkey table
  • Remove the pubkey reserved key from the texts database
  • Redirect setPubkey calls to the newly created table

QA Replication steps

  1. Create a 2LD (e.g techno.eth)
  2. Set its resolver to be the database resolver
  3. Set a pubkey record through the PubkeyResolver interface:
function setPubkey(
    bytes32 node,
    bytes32 x,
    bytes32 y
) external virtual authorised(node)
  1. Check whether this record is being correctly fetched
@pikonha pikonha added the enhancement New feature or request label Oct 7, 2024
@pikonha pikonha added this to the Database Resolver on mainnet milestone Oct 7, 2024
@pikonha pikonha self-assigned this Oct 7, 2024
@pikonha pikonha moved this to 🔖 TODO in ENS Oct 7, 2024
@pikonha pikonha added this to ENS Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 💡 Ideas
Development

No branches or pull requests

1 participant