Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Arbitrum L1Resolver tests on contract #219

Open
2 tasks
pikonha opened this issue Oct 6, 2024 · 0 comments
Open
2 tasks

Add Arbitrum L1Resolver tests on contract #219

pikonha opened this issue Oct 6, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone
Layer 2 implement...

Comments

@pikonha
Copy link
Contributor

pikonha commented Oct 6, 2024 •
edited
Loading

Feature Request

We need to fully test our L1Resolver ensuring it is behaving the way we expect.

Describe Preferred Solution

  • Ensure resolve or any reading calls reverts with OffchainLookup
  • Ensure any writing calls revert with StorageHandledByL2

Architecture Diagram

QA Replication steps
@pikonha pikonha added this to ENS Oct 2, 2024
@pikonha pikonha converted this from a draft issue Oct 6, 2024
@pikonha pikonha added the enhancement New feature or request label Oct 6, 2024
@pikonha pikonha added this to the Layer 2 implementation milestone Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
ENS
Status: 💡 Ideas
Milestone
Layer 2 implementation
Development

No branches or pull requests
1 participant
@pikonha