Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: codemod #4335

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: codemod #4335

wants to merge 4 commits into from

Conversation

Vandivier
Copy link
Contributor

@Vandivier Vandivier commented May 10, 2024 •
edited
Loading

closes #4334

also, allows next.config.js to be recognized as an existing config file.

@Vandivier Vandivier requested a review from flybayer as a code owner May 10, 2024 02:02
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 534de33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Vandivier added 3 commits May 9, 2024 22:29
@Vandivier
feat: use const when appropriate
e3c4b87 
and rm unused import
and rm misleading comment
and add space for readability
@Vandivier
feat: allow next config
ad1b2db 
to be considered
an existing config file
@Vandivier
feat: don't insert dup import
534de33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flybayer flybayer Awaiting requested review from flybayer flybayer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
status/in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

codemod at least has a typo, and maybe other problems
2 participants
@Vandivier @blitzjs-bot