Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zrot #43

Open
kevinsung opened this issue Dec 13, 2023 · 5 comments
Open

Add zrot #43

kevinsung opened this issue Dec 13, 2023 · 5 comments

Comments

@kevinsung
Copy link

kevinsung commented Dec 13, 2023

The zrot function seems to be missing.

https://www.netlib.org/lapack/explore-html/d1/d45/group__rot_gaac9d54e7408105ad6f4c810902e75b7a.html#gaac9d54e7408105ad6f4c810902e75b7a

@IvanUkhov
Copy link
Member

IvanUkhov commented Dec 14, 2023

Hello, blas-sys follows the following reference and zrot is not on the list:

https://www.netlib.org/blas/#_level_1

@kevinsung
Copy link
Author

I see. What list do you follow for LAPACK? As a point of comparison, Scipy has zrot in scipy.linalg.lapack: https://docs.scipy.org/doc/scipy/reference/linalg.lapack.html

@IvanUkhov
Copy link
Member

@IvanUkhov
Copy link
Member

IvanUkhov commented Dec 14, 2023

@kevinsung
Copy link
Author

I see. From looking at Scipy's source code, it looks like Scipy gets zrot from the FORTRAN source code of LAPACK, but zrot has not yet been added to LAPACKE. I have opened Reference-LAPACK/lapack#962 to track adding zrot to LAPACKE. Once that is done, we can add it to the Rust wrapper. It looks like it will belong in https://github.com/blas-lapack-rs/lapack after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants