Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line count is incorrect #1506

Open
wiki-me opened this issue Jul 13, 2020 · 5 comments
Open

line count is incorrect #1506

wiki-me opened this issue Jul 13, 2020 · 5 comments

Comments

@wiki-me
Copy link

wiki-me commented Jul 13, 2020

e.g. openoffice. But it seems like every project is giving graphs that don’t make sense.

This is unfortunate because if i want to share a link to openhub when trying to make point (e.g. that a project is developing rapidly) I can’t do it. If the line count is incorrect that would cause doubt about the reliability of other stats (like commit/contributor stats).

@PDegenPortnoy
Copy link
Contributor

Hi; The project has since been successfully updated and has the latest commit activity. The Languages Summary Page is showing 9.3M total lines, 6.5M code lines based upon the analysis of one enlisted code location, with none of the files in the enlisted code location being excluded.

Does this seem incorrect to you? If so, what seems to be the magnitude of the discrepancy? Might you be able to help us isolate some possible causes?

I would also like to note that line counting is done by our OSS project, Ohcount but that the commit and contributor information is extracted directly from commit history.

@wiki-me
Copy link
Author

wiki-me commented Jul 25, 2020

Does this seem incorrect to you? If so, what seems to be the magnitude of the discrepancy? Might you be able to help us isolate some possible causes?

The problem seems to be in the display of graphs, the numbers seem OK.

on this page, if you will look on the date of november 2019 it shows -7 lines of code. here is a picture to illustrate:

openhub_bug

@wiki-me wiki-me closed this as completed Jul 25, 2020
@wiki-me wiki-me reopened this Jul 25, 2020
@wiki-me
Copy link
Author

wiki-me commented Jul 25, 2020

Accidentally closed it, reopening.

@PDegenPortnoy
Copy link
Contributor

Thank you for the detail. Yes, we've seen this kind of problem before. I'll open a ticket and we'll look into it.

@jtepe
Copy link

jtepe commented Feb 6, 2021

Actually, I think the line count is still incorrect. In case of Go projects (e.g. Prometheus), it counts the vendor directory as well. This directory just includes dependencies put there to pin versions and have reproducible builds.

vendor often contains much more code than the actual project source. For example, Prometheus is listed with > 1.3 million LOC, but the actual project currently has about 100k LOC Go code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants