Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC-55] Adding Docker script to codebase #27

Open
nvatuan opened this issue May 27, 2023 · 1 comment · Fixed by #33
Open

[EPIC-55] Adding Docker script to codebase #27

nvatuan opened this issue May 27, 2023 · 1 comment · Fixed by #33
Assignees
Labels
task New feature or request

Comments

@nvatuan
Copy link
Member

nvatuan commented May 27, 2023

Description:

  • Adding Docker scripts
@nvatuan nvatuan added the task New feature or request label May 27, 2023
@nvatuan nvatuan self-assigned this May 27, 2023
@nvatuan nvatuan moved this from 🆕 New to 🏗 In progress in [bkdnOJ.v2][Backend] Backlog May 27, 2023
@nvatuan nvatuan linked a pull request Jun 4, 2023 that will close this issue
@nvatuan nvatuan moved this from 🏗 In progress to 👀 In review in [bkdnOJ.v2][Backend] Backlog Jun 4, 2023
@nvatuan nvatuan closed this as completed Jun 4, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in [bkdnOJ.v2][Backend] Backlog Jun 4, 2023
@nvatuan
Copy link
Member Author

nvatuan commented Jun 25, 2023

Cách tổ chức Dockerfile cùng với lệnh run không hợp lý lắm, vì chúng ta đang là mono repo gồm nhiều services, các service hiện đang sử dụng chung một list dependencies, nên cứ mỗi lần run một service build lại tốn rất nhiều time. Một cách mà DMOJ đã làm là họ sử dụng một image "base" để rồi pull về và chạy từng service riêng biệt.

Ref: https://github.com/Ninjaclasher/dmoj-docker/tree/master/dmoj

@nvatuan nvatuan reopened this Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant