-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more than one instance of the Ebay API connection #22
Comments
I am going to implement this feature now and use it for my client. I will consider your comments/suggestions before making a PR. |
Just found out that this works:
So, instances of AA and BB can be used for different connections. Not sure if I like this solution. I am bothered by the UPDATE: |
@meismann You still working on this? I guess having an instantiable EBayr::Client class with the same API as the module makes sense. Not sure why including the module as-is in the class wouldn't work... |
Actually, it is done (https://github.com/meismann/ebayr/tree/multiple-instances) and I have been using it for my client since a few days. I need my current PR merged before I can open another one. AFAIK, if I merge my |
Oh, and I need to update the README. So, it is not completely done, admittedly ;-) |
Cool. How about we merge it into the v0.1 branch, and release a gem in the next week or so? |
All right, agreed! |
Use cases:
The new usage pattern may then look like this:
allthewhile maintaining backward compatibility…
The text was updated successfully, but these errors were encountered: