Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initial Workflow Linter v2 #297

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

joseph-flinn
Copy link
Contributor

🎟️ Tracking

🚧 Type of change

  • 🐛 Bug fix
  • 🚀 New feature development
  • 🧹 Tech debt (refactoring, code cleanup, dependency upgrades, etc.)
  • 🤖 Build/deploy pipeline (DevOps)
  • 🎂 Other

📔 Objective

Clean up the initial creation of the refactor of the Workflow Linter after moving to https://github.com/bitwarden/workflow-linter

📋 Code changes

  • ./lint-workflow-v2 Remove after move to bitwarden/workflow-linter

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@joseph-flinn joseph-flinn requested a review from a team as a code owner July 12, 2024 21:16
@bitwarden-bot
Copy link

bitwarden-bot commented Jul 12, 2024

Logo
Checkmarx One – Scan Summary & Detailsf425aa1c-8c83-4794-a892-37cd11938bc2

Fixed Issues

Severity Issue Source File / Package
MEDIUM Path_Traversal /lint-workflow-v2/src/bitwarden_workflow_linter/cli.py: 35
MEDIUM Path_Traversal /lint-workflow-v2/src/bitwarden_workflow_linter/cli.py: 35
MEDIUM Path_Traversal /lint-workflow-v2/src/bitwarden_workflow_linter/cli.py: 35
MEDIUM Path_Traversal /lint-workflow-v2/src/bitwarden_workflow_linter/cli.py: 35
MEDIUM Unpinned Actions Full Length Commit SHA /test.yml: 28
LOW Log_Forging /lint-workflow-v2/src/bitwarden_workflow_linter/cli.py: 35
LOW Log_Forging /lint-workflow-v2/src/bitwarden_workflow_linter/cli.py: 35

vgrassia
vgrassia previously approved these changes Jul 15, 2024
@joseph-flinn joseph-flinn merged commit cc4aa15 into main Jul 17, 2024
4 checks passed
@joseph-flinn joseph-flinn deleted the clean-up-workflow-linter-v2-after-moving branch July 17, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants