Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-1595] - Add supported workflows to linter workflow #221

Merged
merged 10 commits into from
Dec 20, 2023

Conversation

Eeebru
Copy link
Contributor

@Eeebru Eeebru commented Dec 15, 2023

🎟️ Tracking

🚧 Type of change

  • 🤖 Build/deploy pipeline (DevOps)

📔 Objective

📋 Code changes

  • .lint-workflow/* Add supported workflows check to linter workflow

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Eeebru Eeebru requested a review from a team as a code owner December 15, 2023 18:06
lint-workflow/lint.py Outdated Show resolved Hide resolved
@Eeebru Eeebru requested a review from joseph-flinn December 18, 2023 16:39
lint-workflow/lint.py Outdated Show resolved Hide resolved
@joseph-flinn joseph-flinn self-requested a review December 18, 2023 22:48
joseph-flinn
joseph-flinn previously approved these changes Dec 19, 2023
@Eeebru Eeebru merged commit 986d95d into main Dec 20, 2023
2 checks passed
@Eeebru Eeebru deleted the DEVOPS-1595-create-list-of-pre-approved-actions branch December 20, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants