Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODE_SIGN_STYLE should default to "Automatic" for iOS projects. #165

Open
jfrndz opened this issue Apr 22, 2022 · 1 comment
Open

CODE_SIGN_STYLE should default to "Automatic" for iOS projects. #165

jfrndz opened this issue Apr 22, 2022 · 1 comment

Comments

@jfrndz
Copy link

jfrndz commented Apr 22, 2022

log.Debugf("setting CODE_SIGN_STYLE unspecified for target (%s), defaulting to `Manual`", targetName)

Ahoy! Found this while debugging my workflow.

XCode projects that that don't specify CODE_SIGN_STYLE use Automatic code signing per iOS defaults.
Steps like xcode_archive end up setting up Manual code signing for these projects as a result, leading to unexpected code signing issues later in the build.

Not sure if other Apple platforms have different defaults for CODE_SIGN_STYLE.

Explicitly setting CODE_SIGN_STYLE is a workaround.

@ofalvai
Copy link
Contributor

ofalvai commented May 19, 2022

Ahoy @jfrndz - As you mentioned, the code only falls back to manual code sign style if CODE_SIGN_STYLE is not defined in the project settings. Can you help us understand how this can happen in a project (that there is no code sign style defined)?

Side note: if you want to avoid unexpected code signing issues, we recommend disabling the automatic_code_signing input entirely - with this setting, the step won't modify any code signing setting in the project nor install any certificates and profiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants