Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Missing crontab not an error anymore #1953

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+14 −12
Open

fix: Missing crontab not an error anymore #1953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions common/schedule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,19 +61,21 @@ def read_crontab():

Returns:
list: Crontab lines.

Dev notes (buhtz, 2024-05): Might should raise exception on errors.
"""
try:
proc = subprocess.run(
[CRONTAB_COMMAND, '-l'],
check=True,
capture_output=True,
text=True)

except subprocess.CalledProcessError as err:
logger.error(f'Failed to get content via "{CRONTAB_COMMAND}". '
f'Return code of {err.cmd} was {err.returncode}.')
proc = subprocess.run(
[CRONTAB_COMMAND, '-l'],
check=False,
capture_output=True,
text=True)

# Error?
if proc.returncode != 0:
# Ignore missing crontabs
if not proc.stderr.startswith('no crontab for'):
logger.error(f'Failed to get content via "{CRONTAB_COMMAND}". '
f'Return code of {proc.args} was {proc.returncode}. '
f'Stderr: {proc.stderr}')

return []

content = proc.stdout.split('\n')
Expand Down