-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClinicalTrials.gov: 2023 URI update and ctgov prefix #897
Conversation
ctgov might be a better prefix than the current preferred prefix of clinicaltrials because ClinicalTrials.gov is only one of many trial registries as per https://bioregistry.io/collection/0000012. Possible confusion with Connecticut's https://portal.ct.gov/.
ChatGPT answers with ClinicalTrials.gov for "In the context of life science databases, ontologies, and other resources, what does ctgov stand for?" |
@dhimmel thank you for the contribution, the new URI format is great. Can you give me an example where you encountered ctgov as a prefix? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #897 +/- ##
=======================================
Coverage 40.62% 40.62%
=======================================
Files 135 135
Lines 7790 7790
Branches 1809 1809
=======================================
Hits 3165 3165
Misses 4429 4429
Partials 196 196
☔ View full report in Codecov by Sentry. |
I don't know if I've seen it as a CURIE prefix anywhere, but I think it is common to use in column names like Partly this addition is motivated by the existing prefixes at https://bioregistry.io/registry/clinicaltrials being somewhat unsatisfactory, where Also interested in whether anyone knows someone more involved with CT.gov data that could advise? Tagging @micronix in case they have any insights here (I see they are a recent contributor to https://github.com/ctti-clinicaltrials/aact). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhimmel I am convinced after seeing the database schema. Please let me know if you want me to wait for more feedback before merge
If you're referring to the giant AACT schema it looks like it uses both All good on my end, so merge away. More feedback still welcome, but can always make changes later if anything is actionable. |
refs greenelab/covid19-review#1210
Two changes (one per commit) that should be treated as separate (I can remove either of the changes from this PR based on review).