Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClinicalTrials.gov: 2023 URI update and ctgov prefix #897

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

dhimmel
Copy link
Contributor

@dhimmel dhimmel commented Jun 29, 2023

refs greenelab/covid19-review#1210

Two changes (one per commit) that should be treated as separate (I can remove either of the changes from this PR based on review).

dhimmel added 2 commits June 29, 2023 09:34
ctgov might be a better prefix than the current preferred prefix
of clinicaltrials because ClinicalTrials.gov is only one of many
trial registries as per https://bioregistry.io/collection/0000012.

Possible confusion with Connecticut's https://portal.ct.gov/.
@dhimmel
Copy link
Contributor Author

dhimmel commented Jun 29, 2023

Possible confusion with Connecticut's https://portal.ct.gov/.

ChatGPT answers with ClinicalTrials.gov for "In the context of life science databases, ontologies, and other resources, what does ctgov stand for?"

@cthoyt
Copy link
Member

cthoyt commented Jun 29, 2023

@dhimmel thank you for the contribution, the new URI format is great. Can you give me an example where you encountered ctgov as a prefix?

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0b45492) 40.62% compared to head (630d987) 40.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #897   +/-   ##
=======================================
  Coverage   40.62%   40.62%           
=======================================
  Files         135      135           
  Lines        7790     7790           
  Branches     1809     1809           
=======================================
  Hits         3165     3165           
  Misses       4429     4429           
  Partials      196      196           
Impacted Files Coverage Δ
src/bioregistry/version.py 68.42% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dhimmel dhimmel changed the title ClinicalTrials.gov: 2023 prefix and ctgov prefix ClinicalTrials.gov: 2023 URI update and ctgov prefix Jun 29, 2023
@dhimmel
Copy link
Contributor Author

dhimmel commented Jun 29, 2023

Can you give me an example where you encountered ctgov as a prefix?

I don't know if I've seen it as a CURIE prefix anywhere, but I think it is common to use in column names like ctgov_id. Also when writing ClinicalTrials.gov, people will often abbreviate it as CT.gov or CT-gov. Searching via pubmed, about 25-30 publications do this per year. Admittedly that is low compared to the 20k articles that mention ClinicalTrials.gov per year.

Partly this addition is motivated by the existing prefixes at https://bioregistry.io/registry/clinicaltrials being somewhat unsatisfactory, where clinicaltrials looks out of place as a prefix in the Clinical Trial Registries collection. This change is a potential gateway into a future changing the preferred prefix to ctgov, which could be evaluated in the future based on adoption of the ctgov prefix.

Also interested in whether anyone knows someone more involved with CT.gov data that could advise? Tagging @micronix in case they have any insights here (I see they are a recent contributor to https://github.com/ctti-clinicaltrials/aact).

Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhimmel I am convinced after seeing the database schema. Please let me know if you want me to wait for more feedback before merge

@dhimmel
Copy link
Contributor Author

dhimmel commented Jun 29, 2023

If you're referring to the giant AACT schema it looks like it uses both nct and ctgov.

All good on my end, so merge away. More feedback still welcome, but can always make changes later if anything is actionable.

@cthoyt cthoyt merged commit b2b3e1d into biopragmatics:main Jun 29, 2023
@dhimmel dhimmel deleted the dsh-ctgov-new-url branch June 29, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants