Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new provider for pdb: dionysus #1282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nagutm
Copy link
Collaborator

@nagutm nagutm commented Nov 25, 2024

This pull request curates a new provider for PDB structure: dionysus.

PubMed: https://pubmed.ncbi.nlm.nih.gov/39436020/
Database: www.dsimb.inserm.fr/DIONYSUS/

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.48%. Comparing base (8950e70) to head (13b2ab0).
Report is 193 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1282      +/-   ##
==========================================
+ Coverage   42.51%   44.48%   +1.97%     
==========================================
  Files         117      118       +1     
  Lines        8327     8263      -64     
  Branches     1963     1357     -606     
==========================================
+ Hits         3540     3676     +136     
+ Misses       4582     4410     -172     
+ Partials      205      177      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagutm nagutm changed the title Add new provider for PDB: DIONYSUS Add new provider for pdb: dionysus Nov 25, 2024
"year": 2024
}
],
"uri_format": "https://www.dsimb.inserm.fr/DIONYSUS/structure/$1"
Copy link
Contributor

@bgyori bgyori Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried this and one problem here is that the example ID listed for pdb (2gc4) doesn't resolve in this resource, so the example link shown on the web would be broken.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resource only appears to import a filtered set of PDB IDs that are carbohydrate-containing structures and match specific keywords related to the classification tag used by PDB. This explains why 2gc4 cannot be resolved with this uri_format.

I'm not sure how much value there is to curating a provider that cannot resolve all IDs for its parent resource. I think we could consider marking this as not_notable instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't think in itself it's a problem that not every ID is resolved, but I think overall not sure if it's worth adding this given the anticipation of the broken example link.

Copy link
Collaborator Author

@nagutm nagutm Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other possible solution to this could be to curate this as its own prefix and use the "provides" key to signal that it is a PDB provider. That way we could use an example ID that would create a working example link.

@cthoyt cthoyt added Provider Add a new provider New Used in combination with prefix, metaprefix, or collection for new entries labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Used in combination with prefix, metaprefix, or collection for new entries Provider Add a new provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants