Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example files #39

Open
florianhartig opened this issue Jun 27, 2018 · 4 comments
Open

example files #39

florianhartig opened this issue Jun 27, 2018 · 4 comments

Comments

@florianhartig
Copy link
Member

low priority, but I see we have examples directly in the Roxygen code, examples should be in inst/examples, see https://github.com/florianhartig/DHARMa/tree/master/DHARMa/inst/examples

@Rasilgon
Copy link
Collaborator

I was not aware that it should be this way, I thought both were OK. If it's better to have examples in the folder I can move them there.

Note: none of the examples is actually run.

@florianhartig
Copy link
Member Author

it's not a must to have these example files, but much easier to maintain, and easier to check, because in this way you can always run the code through yourself.

When I was checking the examples, a few code lines, for example, wouldn't run, because something was not defined ... having the R scripts in inst really helps for maintenance / checking that all examples still run

@Rasilgon
Copy link
Collaborator

The examples are inst7examples (develop branch). A bit more of context is need, I am working on it.

@Rasilgon
Copy link
Collaborator

Rasilgon commented Jul 1, 2018

This is solved on branch develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants