Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems parsing output from latest obographs library #697

Open
balhoff opened this issue Nov 1, 2024 · 2 comments
Open

problems parsing output from latest obographs library #697

balhoff opened this issue Nov 1, 2024 · 2 comments
Assignees

Comments

@balhoff
Copy link
Contributor

balhoff commented Nov 1, 2024

In GO, we are trying to update to the latest obographs in ROBOT. We have been using owltools, which uses an older obographs release. We noticed this change, which currently upsets the ontobio JSON reader:

owltools:

{
      "definedClassId" : "http://purl.obolibrary.org/obo/GO_0101013",
      "genusIds" : [ "http://purl.obolibrary.org/obo/GO_0005248", "http://purl.obolibrary.org/obo/GO_0008381" ],
      "restrictions" : [ ]
}

robot:

{
      "definedClassId" : "http://purl.obolibrary.org/obo/GO_0101013",
      "genusIds" : [ "http://purl.obolibrary.org/obo/GO_0005248", "http://purl.obolibrary.org/obo/GO_0008381" ]
}

owltools outputs an empty restrictions array, but the newer obographs leaves it out. As pointed out by @cmungall in my issue at obographs, all properties in a JSON schema are optional unless marked required. So ontobio should be able to handle a missing restrictions and treat it as an empty list. I think there are other properties that will trigger this, so the same fix should be applied to all list handling.

cc @kltm @sierra-moxon

@kltm
Copy link
Member

kltm commented Nov 1, 2024

Shadowed as "draft" item in: https://github.com/orgs/geneontology/projects/135
Tagging @pgaudet

@balhoff
Copy link
Contributor Author

balhoff commented Nov 18, 2024

For the ontology build we need to move to the latest version of ROBOT, to stay compatible with the latest Protege, and also to take advantage of new OBO format features which impact several different open issues in the ontology repo. Currently we use owltools for this step (the JSON change is actually in older versions of ROBOT as well), but to help manage technical debt we would like to eliminate owltools from the ontology build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants