-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tool tips on partner icons #431
Comments
In my view, displaying the name on the list might look a bit redundant since many community partner icons already include their name. Additionally, when you click on an icon, the name also appears at the top, which provides clear identification. As an alternative, we could adjust the "Start Exploring" function to apply a filter that shows only resources related to the selected Community Partner. How does that sound? |
To be honest, when I suggested a tooltip I didn't even realise that the name was displayed on the top and it was because my scrollbar was to a level where the top part was not visible. So the only "problem" I see is about clicking on a partner icon when the top part is not visible (because scrollbar already scrolled down). However, I don't have a solution for this (except for the tooltip but I agree it's redundant in normal situation). For example, if I click on any community partner in this situation not much happens which is a little bit confusing. |
Hi there! @ElpadoCan is right. At the moment, when placing the cursor on top of the icons, the name does not appear anymore (@oeway ?). Additionally, the search function is broken when clicking on the icon. When you click on any of the icons, searching for apps or models with that tag is impossible, you need to type it manually. |
I don't think we need to avoid redundancy here. IMO tooltips would be a nice addition. There is some filtering (via types I believe?) happening, but yes, the differences are marginal, which is not ideal. Adding filters, ideally based on compatibility check results, would be great! A partner configuration could specify if the partner view should filter by those compatibility tags or (the default) the simple "ilastik", "biapy", etc... (I might be disregarding existing, but buggy partner filtering) |
Hi Fynn, it'd be super super nice to automatically tag after the CI. Yet, could we also add the "ilastik" or "deepImageJ" automatically to those models that are meant to be compatible? For example, deepImageJ deploys models with format tensorflow's saved_bundled model, trochscript, and eventually onnix. If none of these formats is available, then, the tag shouldn't be there. This type of "requirement" could be defined in the CP's description |
@esgomezm am I understanding correctly that you are suggesting to overwrite (add or remove) the tool tags ("ilastik", "deepimagej", etc) based on CI compatibility checks? note: When I write "overwriting" here I'm only thinking of the tags we report in the I can see that you'd like a third category in addition to "passed" and "failed" that is essentially "should pass, but doesn't". Btw, we should probably also add version specific tags, e.g. "ilastik-1.4-compatible"... |
Yes, this is what I meant. My suggestion came from yours. One of the issues with manual tags is basically that contributors and actually everyone, forget about tagging the models with compatible software, and even notebooks that were used to train the model and export it, or can fine-tune it. For example, there are models sometimes tagged with Ilastik but not with deepImageJ. In theory, the statement "should pass", could come simply from the weights' format (which is what it's used to download the models). That's why I was thinking that tags could be automatically generated in the way you clarified:
About the category "should pass, but doesn't" I'm not that sure because it's basically if it passes the CI or not, but I don't have a strong opinion on this one |
ok, to move forward on this for deepimagej specifically we need to move on bioimage-io/collection#82 |
I'm not sure I understood correctly, but should every community partner have a CI workflow set up? How is a compatibility check performed typically? Should we discuss this in a dedicated issue maybe? Thanks! |
Yes, whenever feasible a community partner should have compatibility checks in place. |
@FynnBe the tooltip get lost because of the CI. it need a
|
Small suggestion, it would be nice to have the name of the software as tool tip on each partner's icon, what do you think? Not a priority at all of course.
Originally posted by @ElpadoCan in bioimage-io/collection#104 (comment)
The text was updated successfully, but these errors were encountered: