Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_newick is two pass, likely can be done in a single pass #8

Open
wasade opened this issue Jun 28, 2016 · 1 comment
Open

parse_newick is two pass, likely can be done in a single pass #8

wasade opened this issue Jun 28, 2016 · 1 comment

Comments

@wasade
Copy link
Member

wasade commented Jun 28, 2016

Currently, the topology is parsed out first, then a second pass is made to pull out name and length information. The reason for this approach is that a name or length is, right now, associated with the opening parenthesis of a node within BP. This was an implementation decision which may make sense to revise. The disconnect with newick is that a name and/or length in newick is associated with the closing parenthesis or none at all in the case of a tip.

@wasade
Copy link
Member Author

wasade commented Jul 11, 2016

scikit-learn's cythonized Stack may be of use, likely wrap's c++'s STL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant