Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

merge work in from pinterest branch #123

Open
binarymatt opened this issue Jan 22, 2013 · 4 comments
Open

merge work in from pinterest branch #123

binarymatt opened this issue Jan 22, 2013 · 4 comments

Comments

@binarymatt
Copy link
Owner

look at the changes in the pinterest branch and see how to best merge those changes into trunk

@wwitzel3
Copy link
Contributor

I was going to take a look at this but I couldn't find a pinterest branch.

@binarymatt
Copy link
Owner Author

the pinterest branch i was looking at was this one: https://github.com/pinterest/pyres. It's actually better described as a fork off a really old version.

@wwitzel3
Copy link
Contributor

Got it, thanks. The non-blocking queue popping and the ability to aggregates is really nice in that fork. I will take a look at it and see if I can come up with an acceptable merge.

@sontek
Copy link
Contributor

sontek commented Jun 11, 2014

They have documented their changes pretty well, the changes aren't that much:

https://github.com/pinterest/pyres/compare/binarydud:master...master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants