Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

refactor: a/b testing feature doesnt track user events #5679

Merged
merged 60 commits into from
Oct 26, 2023
Merged

refactor: a/b testing feature doesnt track user events #5679

merged 60 commits into from
Oct 26, 2023

Conversation

NikitK-deriv
Copy link
Contributor

@NikitK-deriv NikitK-deriv commented Sep 25, 2023 •
edited
Loading

Changes:

Add encryption key for encrypt connection with third-party service
Refactor enableDevMode depends on current NODE
add some features like user_language, country to pass in third-party service
new type of experiments and feature flags usage
Fix trackingCallback feature to work correctly
Under the hood: we changed some .env variables in github secrets and vercel envs

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Sep 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-com ✅ Ready (Inspect) Visit Preview Oct 24, 2023 1:54pm

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 31
🟠 Accessibility 83
🟠 Best practices 75
🟢 SEO 93
🟢 PWA 90

Lighthouse ran on https://deriv-com-git-fork-nikitk-deriv-cro-update-analytic-event.binary.sx/

@NikitK-deriv NikitK-deriv force-pushed the cro-update-analytic-event branch from f45265c to ed66f0d Compare October 3, 2023 07:02
@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

🚀 Smoke test run (4) passed successfully!

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (3) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

🚀 Smoke test run (4) passed successfully!

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (5) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (3) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

🚀 Smoke test run (5) passed successfully!

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (3) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (4) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (5) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@github-actions
Copy link
Contributor

❌ Smoke test run (3) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (4) failed. See logs for details: Visit Action

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
4.2% 4.2% Duplication

@github-actions
Copy link
Contributor

Preview Link: https://cro-update-analytic1.deriv-com-preview-links.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

habib-deriv
habib-deriv approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@habib-deriv habib-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitra-deriv mitra-deriv merged commit 7f7b97b into binary-com:master Oct 26, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mayuran-deriv mayuran-deriv mayuran-deriv approved these changes

@amir-deriv amir-deriv amir-deriv approved these changes

@hasan-deriv hasan-deriv hasan-deriv approved these changes

@habib-deriv habib-deriv habib-deriv approved these changes

@aswathy-deriv aswathy-deriv aswathy-deriv left review comments

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@prince-deriv prince-deriv Awaiting requested review from prince-deriv prince-deriv is a code owner

@mitra-deriv mitra-deriv Awaiting requested review from mitra-deriv mitra-deriv is a code owner

@fasihali-deriv fasihali-deriv Awaiting requested review from fasihali-deriv fasihali-deriv is a code owner

@mohsen-deriv mohsen-deriv Awaiting requested review from mohsen-deriv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@NikitK-deriv @habib-deriv @aswathy-deriv @hasan-deriv @amir-deriv @mayuran-deriv @mitra-deriv